Added object size in show most common type #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
requested changes
Mar 10, 2021
Owner
mgedmin
left a comment
mgedmin
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This is definitely an interesting idea, but I dislike how it makes backwards-incompatible changes to the structure of the return value. Perhaps a second function, typestats_with_sizes() would be better?
Also, I will not merge it without documentation changes.
| for name, count in stats: | ||
| file.write('%-*s %i\n' % (width, name, count)) | ||
| file.write('%-*s - %i - %i - %i\n' % | ||
| (width, name, count[0], count[1], count[0]*count[1])) |
Owner
There was a problem hiding this comment.
This assumes all the objects of the same type are of the same size, which is not necessarily true.
On my laptop sys.getsizeof("a") == 50, but sys.getsizeof("a"*1000) == 1049.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will give object size too in the output