-
Notifications
You must be signed in to change notification settings - Fork 175
Stop AL-Go from purging non AL-Go BC containers. #1828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This PR on the navcontainerhelper side, adds the functionaltiy to check for the AL-Go creator label: microsoft/navcontainerhelper#3983 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prevents AL-Go from purging non-AL-Go Business Central containers during CICD workflows by adding container labeling and selective flushing logic. The change addresses an issue where AL-Go was removing BC containers created by other development processes on self-hosted runners.
Key changes:
- Modified container creation to add "creator=AL-Go" label to AL-Go containers
- Added conditional logic to only purge AL-Go containers unless custom container creation is used
- Moved the cache flushing operation to occur after container configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
During the CICD workflow, AL-Go calls https://github.com/microsoft/navcontainerhelper/blob/main/ContainerHandling/Flush-ContainerHelperCache.ps1, which kills any BC container that has been off for 3 days or more, regardless if that container was created by AL-Go.
This scenario can happen if you use self-hosted GitHub runners on the same machine/VM that you use for other BC development.
Related to issue: #1675