Skip to content

fix misleading comments: Mz uses c (not r) in PPSNARK #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GarmashAlex wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix misleading comments: Mz uses c (not r) in PPSNARK #414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
063c9c6
fix misleading comments: Mz uses c (not r) in PPSNARK
GarmashAlex Sep 5, 2025
591a6a1
Merge branch 'main' into hpp1
srinathsetty Sep 29, 2025
72044ae
Merge branch 'main' into hpp1
srinathsetty Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/spartan/ppsnark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,7 @@ impl<E: Engine, EE: EvaluationEngineTrait<E>> RelaxedR1CSSNARKTrait<E> for Relax
let u: PolyEvalInstance<E> = PolyEvalInstance::batch(&comm_vec, &tau, &eval_vec, &c);

// we now need to prove four claims
// (1) 0 = \sum_x poly_tau(x) * (poly_Az(x) * poly_Bz(x) - poly_uCz_E(x)), and eval_Az_at_tau + r * eval_Bz_at_tau + r^2 * eval_Cz_at_tau = (Az+r*Bz+r^2*Cz)(tau)
// (1) 0 = \sum_x poly_tau(x) * (poly_Az(x) * poly_Bz(x) - poly_uCz_E(x)), and eval_Az_at_tau + c * eval_Bz_at_tau + c^2 * eval_Cz_at_tau = (Az+c*Bz+c^2*Cz)(tau)
// (2) eval_Az_at_tau + c * eval_Bz_at_tau + c^2 * eval_Cz_at_tau = \sum_y L_row(y) * (val_A(y) + c * val_B(y) + c^2 * val_C(y)) * L_col(y)
// (3) L_row(i) = eq(tau, row(i)) and L_col(i) = z(col(i))
// (4) Check that the witness polynomial W is well-formed e.g., it is padded with only zeros
Expand All @@ -1140,8 +1140,8 @@ impl<E: Engine, EE: EvaluationEngineTrait<E>> RelaxedR1CSSNARKTrait<E> for Relax
(0..Cz.len())
.map(|i| U.u * Cz[i] + E[i])
.collect::<Vec<E::Scalar>>(),
w.p.clone(), // Mz = Az + r * Bz + r^2 * Cz
&u.e, // eval_Az_at_tau + r * eval_Bz_at_tau + r^2 * eval_Cz_at_tau
w.p.clone(), // Mz = Az + c * Bz + c^2 * Cz
&u.e, // eval_Az_at_tau + c * eval_Bz_at_tau + c^2 * eval_Cz_at_tau
);

// a sum-check instance to prove the second claim
Expand Down
Loading