-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Enhance icon search with tag support and clickable tag filters #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the icon search functionality in the WPFGallery application by adding tag support, enabling users to search icons by both name and associated tags, and providing clickable tag filters in the icon detail panel.
Key Changes:
- Added tag metadata to the IconData model and IconsData.json file with comprehensive tags for each icon
- Updated search functionality to match against both icon names and tags using case-insensitive comparison
- Implemented clickable tag chips in the icon detail panel that filter icons when clicked
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IconsData.cs | Added Tags property (List) to the IconData model to store tag metadata |
| IconsData.json | Populated with tag arrays for each icon entry, providing searchable keywords |
| IconsPageViewModel.cs | Enhanced OnSearchTextChanged to search both names and tags; added ApplyTagFilter command for tag chip functionality |
| IconsPage.xaml | Added Tags section with clickable chip buttons styled as IconTagChipButtonStyle; updated search label; bound tag buttons to ApplyTagFilter command |
Note: I was unable to review the actual diff hunks for this pull request as they were not provided in the review context. The analysis above is based on examining the current state of the relevant files in the repository. To provide specific line-by-line feedback and identify potential issues in the changes, I would need to see the actual diff hunks showing which lines were added, removed, or modified.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Lazyb0y, can you update the I think both of them should be at parity. |
Sample Applications/WPFGallery/ViewModels/DesignGuidance/IconsPageViewModel.cs
Outdated
Show resolved
Hide resolved
Sample Applications/WPFGallery/ViewModels/DesignGuidance/IconsPageViewModel.cs
Show resolved
Hide resolved
|
@Lazyb0y, will you be able to resolve the comments by the end of the week? Starting next week we will start the publishing process for the application? |
…brush and thickness so the buttons separate from the light background
@dipeshmsft, I've updated Commit: 5716a70 |
Thanks @Lazyb0y. I will pull in the latest changes and verify once. |
Refactored OnSearchTextChanged to better handle selection when the search filter changes. The selected icon is now preserved if possible, restored if no results are found, or set to the first result when the filter is cleared
|
@Lazyb0y, this looks good for merging. Thanks for all your efforts and quick turnaround on PR comments. |
Fix: #633
Fix: #686
Changes
Microsoft Reviewers: Open in CodeFlow