Skip to content

Conversation

@Lazyb0y
Copy link
Contributor

@Lazyb0y Lazyb0y commented Dec 21, 2025

Fix: #633
Fix: #686

Changes

  • Update the icons page search to match either name or tags, so users can find easily
  • Include the tag metadata in 'IconsData.json' and expose it via 'IconData'
  • Show the selected icon's tags as clickable chips in the detail panel
  • Clicking a tag will show all icons with this tag
Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings December 21, 2025 07:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the icon search functionality in the WPFGallery application by adding tag support, enabling users to search icons by both name and associated tags, and providing clickable tag filters in the icon detail panel.

Key Changes:

  • Added tag metadata to the IconData model and IconsData.json file with comprehensive tags for each icon
  • Updated search functionality to match against both icon names and tags using case-insensitive comparison
  • Implemented clickable tag chips in the icon detail panel that filter icons when clicked

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
IconsData.cs Added Tags property (List) to the IconData model to store tag metadata
IconsData.json Populated with tag arrays for each icon entry, providing searchable keywords
IconsPageViewModel.cs Enhanced OnSearchTextChanged to search both names and tags; added ApplyTagFilter command for tag chip functionality
IconsPage.xaml Added Tags section with clickable chip buttons styled as IconTagChipButtonStyle; updated search label; bound tag buttons to ApplyTagFilter command

Note: I was unable to review the actual diff hunks for this pull request as they were not provided in the review context. The analysis above is based on examining the current state of the relevant files in the repository. To provide specific line-by-line feedback and identify potential issues in the changes, I would need to see the actual diff hunks showing which lines were added, removed, or modified.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dipeshmsft
Copy link
Member

@Lazyb0y, can you update the IconsData.json, the information is not yet complete and it has some differences as compared to the one present in WinUI Gallery : https://github.com/microsoft/WinUI-Gallery/blob/main/WinUIGallery/Samples/Data/IconsData.json

I think both of them should be at parity.

@dipeshmsft
Copy link
Member

@Lazyb0y, will you be able to resolve the comments by the end of the week? Starting next week we will start the publishing process for the application?

@Lazyb0y
Copy link
Contributor Author

Lazyb0y commented Dec 24, 2025

@Lazyb0y, can you update the IconsData.json, the information is not yet complete and it has some differences as compared to the one present in WinUI Gallery : https://github.com/microsoft/WinUI-Gallery/blob/main/WinUIGallery/Samples/Data/IconsData.json

I think both of them should be at parity.

@dipeshmsft, I've updated IconsData.json by copying it from the WinUI Gallery repository, so both files are now in parity. Please let me know if any additional adjustments are needed.

Commit: 5716a70

@dipeshmsft
Copy link
Member

@dipeshmsft, I've updated IconsData.json by copying it from the WinUI Gallery repository, so both files are now in parity. Please let me know if any additional adjustments are needed.

Thanks @Lazyb0y. I will pull in the latest changes and verify once.

Refactored OnSearchTextChanged to better handle selection when the search filter changes. The selected icon is now preserved if possible, restored if no results are found, or set to the first result when the filter is cleared
@dipeshmsft
Copy link
Member

dipeshmsft commented Dec 24, 2025

@Lazyb0y, this looks good for merging. Thanks for all your efforts and quick turnaround on PR comments.

@dipeshmsft dipeshmsft merged commit aa851e7 into microsoft:main Dec 24, 2025
8 checks passed
@Lazyb0y Lazyb0y deleted the gallery/icon-search branch December 24, 2025 10:11
@Lazyb0y Lazyb0y restored the gallery/icon-search branch December 24, 2025 10:15
@Lazyb0y Lazyb0y deleted the gallery/icon-search branch December 24, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ WPF Gallery ] Add support for icon search using Tags for icon [ WPF Gallery ] Add controls and icons search functionality

2 participants