Skip to content

Conversation

@arnoldbeiland
Copy link

Closes #33

Not checking the namespace prefix name seemed to be the solution for the bug linked.

However we also have to take care of cases where there are multiple attributes on an element with the same name (from different namespaces). See the test files from the commit:

  • Xliff.OM.Tests/TestData.Xliff.OM.Tests/UnitWithAttributeHavingCustomNsPrefix.xlf (testing the issue)
  • Xliff.OM.Tests/TestData.Xliff.OM.Tests/DocumentWithTwoNamespaces.xlf (testing a case with two version attributes on the xliff element; the one from the "its:" namespace should be considered an extension, while the other one should be set as a property of the corresponding XliffElement).

@msftclas
Copy link

msftclas commented Jan 28, 2020

CLA assistant check
All CLA requirements met.

@VladimirRybalko
Copy link
Contributor

Hi @arnoldbeiland
Thank you very much for your PR.

Unfortunately, this project is dead. However, I created a new fork: Xliff.OM.NetStandar with all latest bugfixes including your changes.

The corresponding Nuget package is also updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom namespace prefixes should be allowed for attributes from known namespaces

3 participants