Skip to content

Conversation

@raujaiswal
Copy link
Contributor

@raujaiswal raujaiswal commented Nov 28, 2025

Context

Design Doc: https://microsoftapc.sharepoint.com/:w:/r/teams/ADOTasksandAgents/_layouts/15/Doc.aspx?sourcedoc=%7BDFED2317-D226-4EC9-A6AB-1E3E53D91934%7D&file=worker%20crash%20handling.docx&action=default&mobileredirect=true

#AB2333253


Description

Provide a concise summary of the changes introduced in this PR.


Risk Assessment (Low / Medium / High)

Assess the risk level and justify your assessment. For example: code path sensitivity, usage scope, or backward compatibility concerns.


Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect the changes.


Additional Testing Performed

List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).


Change Behind Feature Flag (Yes / No)

Can this change be behine feature flag, if not why?


Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).

Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

azure-pipelines-bot and others added 3 commits November 28, 2025 15:33
- Added enhanced crash handling logic with feature flag control
- Implemented dual-mode operation for Plan v7 vs Plan v8+ scenarios
- Added forced completion for Plan v8+ worker crashes
- Enhanced logging for crash detection and completion analysis
- Added notifyServerOfWorkerCrash variable for clear intent
- Maintained backward compatibility with original logic
- Added comprehensive trace logging for debugging
@raujaiswal raujaiswal marked this pull request as ready for review December 2, 2025 06:47
@raujaiswal raujaiswal requested review from a team as code owners December 2, 2025 06:47
@raujaiswal raujaiswal marked this pull request as draft December 3, 2025 09:52
@raujaiswal raujaiswal marked this pull request as ready for review December 5, 2025 09:39
@raujaiswal
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@raujaiswal raujaiswal changed the title Implement enhanced worker crash handling in JobDispatcher Enhanced worker crash handling in JobDispatcher with added crash telemetry Dec 5, 2025
@raujaiswal raujaiswal changed the title Enhanced worker crash handling in JobDispatcher with added crash telemetry Enhanced worker crash handling with added crash telemetry Dec 5, 2025
@raujaiswal raujaiswal changed the title Enhanced worker crash handling with added crash telemetry Enhanced worker crash handling with integrated crash telemetry Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants