Upgrade irqbalance to 1.9.5 #15379
Upgrade irqbalance to 1.9.5 #15379
Conversation
microsoft-github-policy-service
bot
added
Packaging
3.0-dev
| # Normalize unit EnvironmentFile entries | ||
| sed -i \ | ||
| -e 's#^EnvironmentFile=/usr/etc/default/irqbalance\.env#EnvironmentFile=/etc/sysconfig/irqbalance#' \ | ||
| -e '/^EnvironmentFile=-\${prefix}\/etc\/default\/irqbalance/d' \ |
There was a problem hiding this comment.
I'd use # for separators like you did above for consistency and readability.
There was a problem hiding this comment.
@PawelWMS, Thanks for your suggestion. Here is what we are doing with the above second sed expression.
The second sed expression at line 41 deletes the following line from irqbalance.service:
EnvironmentFile=-${prefix}/etc/default/irqbalance
Part of Original Snapshot of the service file:
We are shipping the RPM with only a single environment file under /etc/sysconfig, so the alternate file is not required. Note that the line starts with a - after =, which indicates an optional (alternate) environment file.
If a customer needs additional environment files, they can still configure them using this syntax in the service file. Therefore, we are removing the alternate EnvironmentFile entry. I hope this approach is okay. Please take a look and let me know in case If I am missing anything.
PawelWMS
left a comment
PawelWMS
left a comment
There was a problem hiding this comment.
One minor suggestion, change looks good.
Thank you very much for the review and approval. |
| %changelog | ||
| * Tue Dec 23 2025 Suresh Thelkar <sthelkar@microsoft.com> - 1.9.5-1 | ||
| - Bump to v1.9.5 to include upstream ENOSPC mitigation (PR #312) | ||
| - Drop Patch0 (IRQBALANCE_ARGS) since v1.9.5 defines IRQBALANCE_ARGS="" in irqbalance.env |
There was a problem hiding this comment.
Related Commit:
There was a problem hiding this comment.
Thank you @mfrw for the review and approval.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Upgrade irqbalance to 1.9.5
SPECS/irqbalance/irqbalance.spec
Version bumped 1.9.3 → 1.9.5; Release reset 2 → 1.
Patch0 removed (IRQBALANCE_ARGS) since v1.9.5 defines IRQBALANCE_ARGS="" in irqbalance.env.
Post-install cleanup to remove upstream default env to avoid duplicate: rm %{buildroot}%
{_prefix}/etc/default/irqbalance.env.
Service unit normalized: EnvironmentFile now points to /etc/sysconfig/irqbalance; upstream/env-prefixed entries removed.
SPECS/irqbalance/irqbalance.signatures.json
Source tarball updated to irqbalance-1.9.5.tar.gz with new SHA256.
cgmanifest.json
Component version and downloadUrl updated to v1.9.5.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology