Specify sizes and ranges of DAP integers #583
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generally types/IDs that were only specified as `integer`s are now int32s. I only defined minimums on those that previously had ">0" behavior - Lines and columns are uint64 since they're only ever >0 and we should be able to express more than (u)int32-sized files. With these and other 64-bit types, I set the `minimum` and `maximum` to the max safe floating point integers so as to ensure compatibility with floating-point-based runtimes, like JavaScript and Lua (<=5.2) - variablesReference is defined as uint32 because we consistently define behavior as "when variablesReference is >0" and "<0" is undefined - systemProcessId is an int32. While research shows there are some exotic systems where it _can_ be an int64 (Solaris) it is practically still an int32 (even 64 bit Linux limits to 2^22) and we have already defined it as such elsewhere - Memory-related offset/count is defined as int64 - namedVariables/indexedVariables are counts, but they were previously specified as having a max value of `2147483647` so I kept them as int32's with a `minimum` value in the schema I would greatly appreciate folks that use various DAP clients to try this out and let me know if you run into issues or see things that should be changed. I'll keep this PR open for a while before merging it to gather feedback. Closes #422 Closes #551
connor4312
force-pushed
the
connor4312/422
branch
from
51fc6f2 to
d97ee9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integers are now int32s.minimumandmaximumto the max safe floating point integers so as to ensure compatibility with floating-point-based runtimes, like JavaScript and Lua (<=5.2)2147483647so I kept them as int32's with aminimumvalue in the schemaI would greatly appreciate folks that use various DAP clients to try this out and let me know if you run into issues or see things that should be changed. I'll keep this PR open for a while before merging it to gather feedback.
cc @osiewicz @mfussenegger @DanTup @octo @puremourning @gregg-miskelly
Closes #422
Closes #551