refactor: Update User-Agent #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: semantic pr
chore: Introduce release workflowc
… commit SHA Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
…workflow feat(ci): enhance create-release workflow with commit targeting and rich error feedback
… commit SHA Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
Co-authored-by: ayeshurun <98805507+ayeshurun@users.noreply.github.com>
…ost-app-user-agent
aviatco
reviewed
Dec 25, 2025
aviatco
reviewed
Dec 29, 2025
| def _get_host_app() -> str: | ||
| """Get the HostApp suffix for the User-Agent header based on environment variables. | ||
| Returns an empty string if the environment variable is not set or has an invalid value. |
Collaborator
There was a problem hiding this comment.
Do we want to print warning in those cases?
More broadly, what is the purpose of the host_app value in the request headers?
aviatco
reviewed
Dec 29, 2025
|
|
||
| host_app = f" host-app/{host_app_name.lower()}" | ||
|
|
||
| # Check for optional version |
Collaborator
There was a problem hiding this comment.
nit - remove "what" comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
Adding a
HostAppidentifier to theUser-Agentstring for all API requests.✨ Description of new changes
User-Agentstring now includes ahost-appsuffix (e.g.,host-app/vscode-extension) if theFAB_HOST_APPenvironment variable is set to a valid, whitelisted value.FAB_HOST_APP_VERSIONenvironment variable is set to a valid version format, the host-app value in User-Agent header will be resulted in 'host-app//'User-Agentis now in a dedicated_build_user_agentfunction insrc/fabric_cli/client/fab_api_client.py.ALLOWED_FAB_HOST_APP_VALUES, has been added tosrc/fabric_cli/core/fab_constant.pyto maintain a list of approvedHostAppvalues.tests/test_core/test_fab_api_client.pyto validate the new functionality, including case-insensitivity and handling of invalid values.🛡️ Security
To ensure that only approved applications can be identified, the value of the environment variable is checked against the
ALLOWED_FAB_HOST_APP_VALUESlist.