Add PlatformDiskId to VirtualHardDisk #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanMSFT
changed the title
blairurish
reviewed
Oct 10, 2025
Contributor
blairurish
left a comment
blairurish
left a comment
There was a problem hiding this comment.
Could we also check in the auto generated changes to the .pb.go files?
blairurish
reviewed
Oct 10, 2025
Contributor
Author
Done |
madhanrm
reviewed
Oct 14, 2025
rpc/cloudagent/storage/virtualharddisk/moc_cloudagent_virtualharddisk.proto
Outdated
Show resolved
Hide resolved
YuanMSFT
changed the title
madhanrm
previously approved these changes
Oct 15, 2025
madhanrm
reviewed
Oct 16, 2025
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
madhanrm
approved these changes
Oct 22, 2025
blairurish
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the PlatformDiskId which will be calculated from the virtual disk ID to VirtualHardDisk, which will be used by azstackhci-operator and stored in the ARM resource later as UniqueID.
This will help customers use the UniqueID to map the ARM resource to an attached disk. Customers can use the Get-Disk or Get-PhysicalDisk PowerShell cmdlets to retrieve the unique ID of the attached disk inside a Windows guest VM and use it to identify the corresponding ARM resource. For Linux VMs, customers can use lsblk to retrieve the serial number of the attached disk and use it to identify the matching ARM resource by comparing it with the unique ID value in the ARM resource.
For example, a partner building a VM migration solution without a dependency on Active Directory will need to consume this.