Skip to content

Conversation

@gramalingam
Copy link
Collaborator

@gramalingam gramalingam commented Dec 16, 2025

The check for removing unused initializers in the constant-folder was not handling the case where the initializer is a graph output.

Fix #2728

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.07%. Comparing base (fb6b40f) to head (aee326a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2732   +/-   ##
=======================================
  Coverage   70.07%   70.07%           
=======================================
  Files         226      226           
  Lines       27276    27276           
  Branches     2754     2754           
=======================================
  Hits        19113    19113           
  Misses       7213     7213           
  Partials      950      950           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Collaborator

@copilot is there a test you can create?

Copy link
Contributor

Copilot AI commented Dec 16, 2025

@justinchuby I've opened a new pull request, #2733, to work on those changes. Once the pull request is ready, I'll request review from you.

@justinchuby justinchuby merged commit f958061 into main Dec 16, 2025
33 checks passed
@justinchuby justinchuby deleted the rama/init-bug branch December 16, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Optimizer bug on cond

4 participants