Dev/allancascante/deploy operation/notification fixes #2546
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 24, 2025 11:51
…tps://github.com/microsoft/sqltoolsservice into dev/acascante/DeployOperation/notification_fixes
… operations can report a more specific type and calling services could treat the results differently.
allancascante
requested review from
Benjin,
aasimkhan30,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
llali,
manujoseph85 and
ssreerama
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DacFx operations such as dacpac or bacpac, are specializations of SqlTask; in some cases the calling service would like to be notified of such operations completed and based on the type do a different treatment. As reported in this bug: microsoft/vscode-mssql#20606 where there is an extra notification to open the generated file, while the default SqlTask is reporting as completed. With the information passed with this changes the calling service could decide customization to the reports of the operations, and allow more concrete UX.
Code Changes Checklist
dotnet test)Reviewers: Please read our reviewer guidelines