fix: append dont clear #440
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianmcgillion
force-pushed
the
fix-writableStore
branch
from
1acf2a8 to
a0311e0
Compare
Contributor
Author
|
@astro could I ask for a review? |
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
Also I just wanted to let you know that we don't use semantic commits.
brianmcgillion
force-pushed
the
fix-writableStore
branch
from
a0311e0 to
a0f525b
Compare
brianmcgillion
changed the title
nixos-modules/microvm/mounts.nix
Outdated
Comment on lines
90
to
91
| } // lib.optionalAttrs isRwStoreVirtiofsShare { | ||
| options = [ "userxattr" ]; |
Member
There was a problem hiding this comment.
Suggested change
| } // lib.optionalAttrs isRwStoreVirtiofsShare { | |
| options = [ "userxattr" ]; | |
| options = lib.mkIf isRwStoreVirtiofsShare [ "userxattr" ]; |
We should really use this 😅
lib.optional returns the empty set [] when a check is false. In the default state this causes the options to be set to an empty list which the module does not allow. So append the new options only if isRwStoreVirtiofsShare is true. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
brianmcgillion
force-pushed
the
fix-writableStore
branch
from
a0f525b to
8730a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.optional returns the empty set [] when a check is false. In this case it causes the options to be set to an empty list which the module does not allow. So append the new options if true.
issue introduced from (#419)