tests: prepare for phpunit 10 #842
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
=========================================
Coverage 98.56% 98.56%
Complexity 389 389
=========================================
Files 24 24
Lines 909 909
=========================================
Hits 896 896
Misses 13 13 ☔ View full report in Codecov by Sentry. |
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| abstract class NamedSelectorTest extends TestCase | ||
| abstract class AbstractNamedSelector extends TestCase |
There was a problem hiding this comment.
What was the purpose of this class renaming?
There was a problem hiding this comment.
PHPUnit 10 will raise a warning, if there are classes with the Suffix Test and no tests or abstract Classes. sebastianbergmann/phpunit#4979 (comment)
sebastianbergmann/phpunit#4979 (comment)
There was a problem hiding this comment.
The CI Tests failed because of this
There was a problem hiding this comment.
I would actually use TestCase as suffix here
There was a problem hiding this comment.
ok, I removed the prefix and added your suggested suffix.
aik099
left a comment
aik099
left a comment
There was a problem hiding this comment.
@Chris53897 , what is the general purpose of renaming *Test classes into *TestCase classes?
|
@aik099 PHPUnit 10 does not allow have abstract classes ending with |
Chris53897
force-pushed
the
feature/prepare-for-phpunit-10
branch
from
32c5948 to
842928e
Compare
|
I changed the Filenames. I hope everything is correct now |
stof
force-pushed
the
feature/prepare-for-phpunit-10
branch
from
d0939bb to
dd0d274
Compare
4 participants
add static data generators
fix deprecated file-structure for abstract test classes