-
Notifications
You must be signed in to change notification settings - Fork 286
chore: allow Symfony 8 #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
============================================
- Coverage 98.72% 98.56% -0.16%
Complexity 389 389
============================================
Files 24 24
Lines 1022 908 -114
============================================
- Hits 1009 895 -114
Misses 13 13 ☔ View full report in Codecov by Sentry. |
|
@nikophil , Test passes, but in used dependencies I'm still seeing Symfony 7. Is there something else, that needs to be changed to use Symfony 8 in tests? |
6a8ca5c to
18a8ea2
Compare
18a8ea2 to
2998eb5
Compare
|
Now the PHP 7.3 and PHP 7.4 tests started to fail with the |
|
@aik099 yeah sorry I should have checked this Symfony 8 is still in beta, it would need the I've changed the PHP version used with some other workflows fail, but it seems totally unrelated 🤔 |
Might not be unrelated. We just don't see the relation.
Probably changing from 8.2 to 8.4 has somehow affected 7.3 and 7.4 builds. Also recent build from the https://github.com/minkphp/Mink/actions/runs/19314012745 passes. |
|
I see now. Previously the PHP 7.4 build installed Composer 2.8.12 and PHPUnit checking the Not sure why GitHub Actions step installing PHP decided to use different Composer version all of the sudden. |
|
it was released 3 hours ago 😁 |
No description provided.