Skip to content

Conversation

@nikophil
Copy link
Contributor

@nikophil nikophil commented Nov 9, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (916471d) to head (2998eb5).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #875      +/-   ##
============================================
- Coverage     98.72%   98.56%   -0.16%     
  Complexity      389      389              
============================================
  Files            24       24              
  Lines          1022      908     -114     
============================================
- Hits           1009      895     -114     
  Misses           13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099
Copy link
Member

aik099 commented Nov 13, 2025

@nikophil , Test passes, but in used dependencies I'm still seeing Symfony 7. Is there something else, that needs to be changed to use Symfony 8 in tests?

@aik099
Copy link
Member

aik099 commented Nov 13, 2025

Now the PHP 7.3 and PHP 7.4 tests started to fail with the Undefined property: Composer\BinProxyWrapper::$realpath error. Not sure how it's related to Symfony 8.x.

@nikophil
Copy link
Contributor Author

nikophil commented Nov 13, 2025

@aik099 yeah sorry I should have checked this

Symfony 8 is still in beta, it would need the minimum-stability to be beta or dev. This flag is currenlt passed for PHP 8.2, but SF 8 requires PHP 8.4

I've changed the PHP version used with minimum-stability: dev. It's OK now https://github.com/minkphp/Mink/actions/runs/19331656124/job/55295974240?pr=875#step:5:42

some other workflows fail, but it seems totally unrelated 🤔

@aik099
Copy link
Member

aik099 commented Nov 13, 2025

some other workflows fail, but it seems totally unrelated

Might not be unrelated. We just don't see the relation.

Probably changing from 8.2 to 8.4 has somehow affected 7.3 and 7.4 builds.

Also recent build from the https://github.com/minkphp/Mink/actions/runs/19314012745 passes.

@aik099
Copy link
Member

aik099 commented Nov 13, 2025

I see now. Previously the PHP 7.4 build installed Composer 2.8.12 and PHPUnit checking the Composer\BinProxyWrapper::$realpath property was happy. Now it started to install Composer 2.9.0 and PHPUnit checking an undefined property isn't happy anymore.

Not sure why GitHub Actions step installing PHP decided to use different Composer version all of the sudden.

@nikophil
Copy link
Contributor Author

it was released 3 hours ago 😁

https://github.com/composer/composer/releases/tag/2.9.0

@stof stof merged commit d2eb7ec into minkphp:master Nov 22, 2025
33 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants