Skip to content

Conversation

@stof
Copy link
Member

@stof stof commented Nov 22, 2025

  • add more precise types for some array parameters
  • ignore missing iterable value errors only for the selector and locator arguments related to our SelectorInterface rather than disabling the check globally

- add more precise types for some array parameters
- ignore missing iterable value errors only for the selector and locator
  arguments related to our SelectorInterface rather than disabling the
  check globally
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.56%. Comparing base (4897dc4) to head (05ffb4e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #878   +/-   ##
=========================================
  Coverage     98.56%   98.56%           
- Complexity      349      389   +40     
=========================================
  Files            24       24           
  Lines           909      909           
=========================================
  Hits            896      896           
  Misses           13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stof stof merged commit 7e1f389 into minkphp:master Nov 22, 2025
14 checks passed
@stof stof deleted the improve_phpstan branch November 22, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant