Skip to content

Conversation

@stof
Copy link
Member

@stof stof commented Feb 4, 2015

Symfony 2.2 is EOLed since 1 year: http://symfony.com/roadmap?version=2.2#checker

I think we can be fine with dropping the support for it in the next minor version of the driver (1.3.0) rather than bumping the major version.

People using Mink inside Behat already lost the compatibility with these unmaintained Symfony versions anyway btw, and I don't think anyone should be using unmaintained versions, so it is acceptable IMO (people who don't update their Symfony dependency will be fine with not updating their Mink driver anyway)

@stof
Copy link
Member Author

stof commented Feb 4, 2015

note that we already dropped the testing for these versions a while ago (we rely on Silex for the testsuite, and it does not support these Symfony versions anymore)

@stof
Copy link
Member Author

stof commented Feb 4, 2015

This is a cherry-pick of the second commit of #44 btw.

@aik099
Copy link
Member

aik099 commented Feb 4, 2015

I think, that first we need to release next minor driver version with update for supporting new findElementXpaths method. Then we can merge this PR (no need to release immediately after this PR is merged).

@stof
Copy link
Member Author

stof commented Feb 5, 2015

@aik099 do we need 2 different minor versions for these ?

@stof stof force-pushed the bump_symfony_deps branch from 0062335 to abcdf72 Compare February 5, 2015 22:57
@aik099
Copy link
Member

aik099 commented Feb 6, 2015

I'm not sure at 100%. Removing compatibility is BC break after all.

@stof
Copy link
Member Author

stof commented Feb 21, 2015

@aik099 I'm removing the compatibility for versions which are unmaintained since more than 1 year (I'm talking about the end for security maintenance).

@aik099
Copy link
Member

aik099 commented Feb 21, 2015

OK.

stof added a commit that referenced this pull request Feb 21, 2015
Removed the BC layers for Symfony 2.2 and older
@stof stof merged commit 74ffe69 into minkphp:master Feb 21, 2015
@stof stof deleted the bump_symfony_deps branch February 21, 2015 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants