Skip to content

fix: use semantic figure and caption tags #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahtesham-quraish merged 2 commits into from
Dec 19, 2025
+5 −4
Merged

fix: use semantic figure and caption tags #2826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c4f687
fix: use semantic figure and caption tags
Dec 19, 2025
483db60
fix caption issue on media embed
Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ends/ol-components/src/components/TiptapEditor/extensions/node/Image/ImageWithCaption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const ARTICLE_MAX_WIDTH = 890
const CONTAINER_PADDING = 24
const WIDE_LAYOUT_MIN_IMG_WIDTH = 900

const Container = styled.div(({ theme }) => ({
const Container = styled.figure(({ theme }) => ({
position: "relative",
margin: "2rem auto",
textAlign: "center",
Expand Down Expand Up @@ -148,7 +148,7 @@ const Image = styled.img<{ layout: Layout }>(({ layout }) => ({
},
}))

const Caption = styled.p(({ theme }) => ({
const Caption = styled.figcaption(({ theme }) => ({
"&&&&&": {
...theme.typography.body2,
color: theme.custom.colors.silverGrayDark,
Expand Down
5 changes: 3 additions & 2 deletions ...-components/src/components/TiptapEditor/extensions/node/MediaEmbed/MediaEmbedNodeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ const StyledNodeViewWrapper = styled(NodeViewWrapper)<{
input {
width: 100%;
border: none;
text-align: center;
text-align: left;
outline: none;
padding: 4px;
padding: 16px 0;
font-size: 14px;
border-bottom: 1px solid #dde1e6;
}
p {
Expand Down
Loading