refactor: logging.exception #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors exception handling to use bt.logging.exception() instead of manually logging errors and printing stack traces. The main benefits are cleaner code and automatic stack trace inclusion in exception logs.
Key Changes
- Replaced
bt.logging.error()+traceback.print_exc()patterns withbt.logging.exception() - Removed unused
tracebackandsysimports across multiple files - Moved asset validation logic from
Validatorclass toPriceDataProvider.__init__()
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| synth/validator/price_data_provider.py | Added __init__ method with asset validation moved from validator |
| synth/validator/miner_data_handler.py | Replaced manual exception logging with bt.logging.exception() across 11 exception handlers |
| synth/base/validator.py | Simplified exception handling in validator run loop |
| synth/base/miner.py | Replaced traceback.format_exc() with bt.logging.exception() |
| synth/base/dendrite.py | Updated exception logging in log_exception function |
| neurons/validator.py | Updated PriceDataProvider instantiation and removed duplicate asset validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.