Consolidate repetitive model instantiations across tests

[zigzagdev]

Description

This pull request refactors the test suite to eliminate redundant model instantiations. Several test cases repeatedly constructed identical User, Item, and Book model objects inline, leading to code duplication and reduced maintainability.

To address this:

• A set of factory-like helper methods has been introduced to create consistent test data.
• All repeated inline instantiations were replaced by these shared methods.
• This improves readability, enforces consistency, and simplifies future updates.

This is a non-functional change (refactor only) and does not alter the behaviour or scope of any existing tests.

Checklist

• Add tests and ensure they pass

[Copilot]

Pull request overview

This PR refactors the test suite to reduce code duplication by introducing a factory-like helper method for creating test User instances. The changes replace multiple identical inline model instantiations with calls to a centralized makeUser() method, improving maintainability and consistency.

Key changes:

• Added makeUser() helper method to eliminate repetitive User model instantiation
• Added setUp() method to properly initialize Carbon test time
• Added missing return type declarations to test methods

Comments suppressed due to low confidence (1)

tests/ModelTest.php:1

• The screenshot filename references '2025-06-24', which is a future date (current date is December 8, 2025). This appears to be an incorrect timestamp in the screenshot filename.

<?php

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The helper method makeUser() has private visibility, which prevents subclasses from reusing this factory method. Consider changing it to protected to allow test class inheritance and reuse of the helper.

Suggested change

	private function makeUser(): User
	protected function makeUser(): User

[Copilot]

The makeUser() method calls save() which performs a database operation. This tightly couples test data creation with persistence. Consider separating concerns by having the method only construct the user object and letting individual tests decide when to save, or alternatively rename to createUser() to better reflect that it persists data.

Suggested change

	$user->save();
	return $user;
	}
	public function testInsert(): void
	{
	$user = $this->makeUser();
	return $user;
	}
	public function testInsert(): void
	{
	$user = $this->makeUser();
	$user->save();

[GromNaN]

Thank you @zigzagdev