Reuse ConnectionSource to avoid extra server selection. #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # driver-core/src/main/com/mongodb/internal/operation/ChangeStreamBatchCursor.java # driver-core/src/main/com/mongodb/internal/operation/SyncOperationHelper.java # driver-core/src/test/unit/com/mongodb/internal/operation/ChangeStreamBatchCursorTest.java
rozza
reviewed
Nov 20, 2025
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
Checkstyle nits - will remove and re run the tests.
driver-core/src/test/unit/com/mongodb/internal/operation/ChangeStreamBatchCursorTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/operation/ChangeStreamBatchCursorTest.java
Outdated
Show resolved
Hide resolved
rozza
reviewed
Nov 20, 2025
| protected abstract MongoClient createMongoClient(MongoClientSettings mongoClientSettings); | ||
|
|
||
| @Test | ||
| public void shouldDoOneServerSelectionForResumeAttempt() { |
Member
There was a problem hiding this comment.
Seems to have failed a couple of times in the tests:
Member
Author
There was a problem hiding this comment.
Ah, 10107 error code (MongoNotPrimaryException) that was returned from failPoint marked a primary as UNKNOWN, so it caused multiple server selections until the server monitor discovered the primary. I have changed to a different retryable error code - 9001.
All tests pass now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5974