[CLOUDP-361632] Add functionality to upload release info to GitHub release assets #624

viveksinghggits · 2025-12-03T14:03:26Z

Summary

As discussed in the base PR, customers have been asking us to provide some details that can be used to figure out the container images that they need to deploy a specific version of MCK and MongoDB instance.
This PR does that. It add the functionality to add a new file called release_info_<release-version>.json to the GitHub release assets that would contain the details about MCK released images, OM, Agent, Search and the mapping between OM and agent's latest versions.

This is how the file loos like

https://gist.github.com/viveksinghggits/560e6179a3c7d9b11b0df68f02b15ccc

Proof of Work

Run the patch manually

evergreen patch --path .evergreen.yml -p mongodb-kubernetes -v add_releaseinfo_to_github_assets -t add_releaseinfo_to_github_assets -f -y -u --browse -d "Test add release info to github assets"

and make sure the new file is added to the release.

Screen.Recording.2025-12-02.at.23.00.35.mov

Screen.Recording.2025-12-02.at.23.08.27.mov

Checklist

Have you linked a jira ticket and/or is the ticket in the title?
Have you checked whether your jira ticket required DOCSP changes?
Have you added changelog file? (will show up later)
- use skip-changelog label if not needed
- refer to Changelog files and Release Notes section in CONTRIBUTING.md for more details

viveksinghggits · 2025-12-03T14:05:03Z

Hi @MaciejKaras , @nammn @mircea-cosbuc @vinilage ,
I had to re-open the PR that was already being reviewed here #623, the branch that was used in other PR was such that I was not able to push any new changes.
I have addressed the comment in this PR. can you please take a look again.

thank you, sorry for the confusion.

scripts/release/release_info.py

MaciejKaras · 2025-12-03T14:24:57Z

.evergreen-release.yml

+    run_on:
+      - ubuntu2404-small
+    allowed_requesters: ["patch", "github_tag"]
+    # depends_on:


why this is still commented out?

I will remove this, I have commented this out because I don't want to mistakenly release the images while testing this.

Sure, understand. Let's keep the thread unresolved until this is uncommented.

scripts/release/release_info.py

.evergreen-release.yml

viveksinghggits · 2025-12-03T14:37:06Z

.evergreen-release.yml

+    run_on:
+      - ubuntu2404-small
+    allowed_requesters: ["patch", "github_tag"]
+    # depends_on:


I will remove this, I have commented this out because I don't want to mistakenly release the images while testing this.

scripts/release/release_info.py

MaciejKaras · 2025-12-05T10:12:22Z

scripts/release/build/image_build_process.py

+            raise e
+
+    def get_manfiest_list_digest(self, image) -> Optional[str]:
+        self.pull_image(image)


Pulling Ops Manager (which is huge) and other images just to get the digest seems like an overkill. Are we sure there is no other way?

I looked into these ways of figuring out manifest list digest.

docker_cmd.buildx.imagetools.inspect(image_tag)

The python client that we are using doesn't return the manifest list digest, even though the respective CLI returns the required digest. So we can not use this way. I raised an issue upstream.

docker manifest inspect

Does not return the manifest list digest.

docker_cmd.image.inspect(image)

Works well and expects image to be pulled first.

docker inspect

Works well and expects image to be pulled locally.

The overall process of making the release_info file is taking less than 10 (~6) seconds.

The other option is to call HTTP API of container registry to figure the information out.

Now that I was thinking about it again, the other option is to not use the python module and just run docker buildx imagetools inspect command directly. The small problem with this approach is, in the other functions we will be using the python package but in one method we will be running docker command directly.

Why not use https://github.com/containers/skopeo to inspect remote images? It's the ideal tool for this case.

I have used skopeo now to get the manifest list digest.

scripts/release/build/image_build_process.py

scripts/release/kubectl_mongodb/utils.py

github-actions · 2025-12-05T16:44:27Z

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.1 Release Notes

Bug Fixes

Backed up the agent password in a secret for SCRAM authentication to prevent unnecessary password rotations.
MongoDB Adding missing ownerrefs to ensure proper resource deletion by kubernetes.
Single Cluster Deleting resources created by CRD now only happens on multi-cluster deployments. Single Cluster will solely rely on ownerrefs.
MongoDB, MongoDBOpsManager: Improve validation for featureCompatibilityVersion field in MongoDB and MongoDBOpsManager spec.
The field now enforces proper semantic versioning. Previously, invalid semver values could be accepted,
potentially resulting in incorrect configurations.

1. Move mapping field in json to root level 2. Change log lever for logs

… level

1. Use `docker run skopeo inspect` to get digest of manifest list of a container image instead of docker inspect 2. Write unit test

nammn · 2025-12-08T08:16:38Z

scripts/release/tests/release_info_test.py

+                "digest": "sha256:ca4aad523f14d68fccb60256f9ce8909c66ebb5b321ee15e5abf9ac5738947f9"
+            },
+            "agent": {
+                "repoURL": "quay.io/mongodb/mongodb-agent",


you've changed repositories from a slice to a string.
The agents are released - as of right now - to 2 different repositories, how would we reflect that now?

Good question! The idea is to share information only about main repository. The other repository we push agent to mongodb-agent-ubi is used for backward compatibility issue. Related comment -> https://github.com/mongodb/mongodb-kubernetes/pull/624/files#r2597674694

MaciejKaras · 2025-12-08T08:59:24Z

scripts/release/release_info.py

+    add_image_info(
+        release_info_output,
+        OPS_MANAGER_IMAGE,
+        om_build_info.repositories[0],


b: We should change the build_info.json instead and instead of having array of repositories there, rather something like this:

"release": { "sign": true, "olm-tag": true, "skip-if-exists": true, "repository": "quay.io/mongodb/mongodb-agent", "secondary-repositories": ["quay.io/mongodb/mongodb-agent-ubi"], "platforms": [ "linux/arm64", "linux/amd64", "linux/s390x", "linux/ppc64le" ] }

cc @nammn

Hi @MaciejKaras,
Even though I agree with the change, I don't think this change should be part of the current PR. If you agree, I have raised this CLOUDP ticket https://jira.mongodb.org/browse/CLOUDP-363995 and we can work on this separately.

If you still think the change should be part of this PR, I can make the change.

It doesn't have and even shouldn't be part of this change. I would rather see this is a prerequisite, separate change. I wouldn't want to have xx_build_info.repositories[0] and hardcoded AGENT_IMAGE_REPOSITORY values in master. My recommendation would be to create a separate PR that splits the repositories field and merge it first (or stack the current PR on top)

ok, so do you think we can merge this PR as it is and then can work on the CLOUDP ticket that I have raised, or do you think we should work on the CLOUDP ticket first and then the merge this PR after refactor?

viveksinghggits requested a review from a team as a code owner December 3, 2025 14:03

viveksinghggits requested review from MaciejKaras, lucian-tosa, mircea-cosbuc, nammn and vinilage and removed request for a team and lucian-tosa December 3, 2025 14:03

MaciejKaras reviewed Dec 3, 2025

View reviewed changes

scripts/release/release_info.py Show resolved Hide resolved

MaciejKaras reviewed Dec 3, 2025

View reviewed changes

scripts/release/release_info.py Outdated Show resolved Hide resolved

viveksinghggits requested a review from MaciejKaras December 3, 2025 14:45

viveksinghggits force-pushed the asset-image-info-json branch from 2f6ea42 to f5fcd0d Compare December 4, 2025 14:59

viveksinghggits commented Dec 4, 2025

View reviewed changes

MaciejKaras reviewed Dec 5, 2025

View reviewed changes

scripts/release/build/image_build_process.py Show resolved Hide resolved

MaciejKaras reviewed Dec 5, 2025

View reviewed changes

scripts/release/kubectl_mongodb/utils.py Outdated Show resolved Hide resolved

Base automatically changed from latest-om-agent-mapping to master December 5, 2025 13:51

viveksinghggits added 10 commits December 5, 2025 17:45

Add information about latest OM and agent in release.json

ce0b9de

Address review comments

2fe85da

1. Move mapping field in json to root level 2. Change log lever for logs

Add functinality to upload release info to GitHub release assets

b9bf260

Accommodate the change of moving latestOpsManagerAgentMapping to root…

fcf77cc

… level

Address review comments, refactor

2b5e01a

Add readiness probe as separate image

3de6fe2

Change the format of the relese_info file

da1847d

Add image mongodb-enterprise-server

41d0ca8

Run precommit

a975872

Uncomment unnecessarily commented code

63b6cd1

viveksinghggits added 2 commits December 5, 2025 17:46

Handle exceptions properly

a59ec39

Address review comments

f0a8b0f

1. Use `docker run skopeo inspect` to get digest of manifest list of a container image instead of docker inspect 2. Write unit test

viveksinghggits force-pushed the asset-image-info-json branch from d7108d6 to f0a8b0f Compare December 5, 2025 16:46

Fix rebase messup

f449247

viveksinghggits requested a review from MaciejKaras December 5, 2025 16:51

nammn reviewed Dec 8, 2025

View reviewed changes

MaciejKaras reviewed Dec 8, 2025

View reviewed changes

[CLOUDP-361632] Add functionality to upload release info to GitHub release assets #624

Are you sure you want to change the base?

[CLOUDP-361632] Add functionality to upload release info to GitHub release assets #624

Conversation

viveksinghggits commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Proof of Work

Checklist

Uh oh!

viveksinghggits commented Dec 3, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MaciejKaras Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

viveksinghggits Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

docker_cmd.buildx.imagetools.inspect(image_tag)

docker manifest inspect

docker_cmd.image.inspect(image)

docker inspect

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Dec 5, 2025

MCK 1.6.1 Release Notes

Bug Fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

viveksinghggits commented Dec 3, 2025 •

edited

Loading

MaciejKaras Dec 5, 2025 •

edited

Loading

viveksinghggits Dec 5, 2025 •

edited

Loading