update qapps/vapps to vue3 and quasar2 #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll setURL twice. Also corrected errors in m-editable
Member
|
@newmann Thanks for the PR. One change since the original conception of vue3quasar2 is we created a new render mode called qvt2 and vuet2 and left qvt / vuet as it currently is to not break the existing functionality. If this PR can be refactored to adjust for that change then I'd be happy to check it out again and in less time. Let me know if you need anything for that. |
Contributor
Author
|
If it is decided to add a new rendering mode, corresponding modifications are indeed necessary. The PR I submitted is not much different from the original approach, so it is recommended to use the original solution. Since qvt2 is merely an upgrade of qvt, why should qvt be retained? Wouldn't it be better to upgrade them together? Or are there other plans? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method minimizes the changes to the original program structure