Update moe branch for torchrun and fix error while loading trainer.ds_module #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue "[rank0]: RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!" On DeepSpeed library 0.15.0, the commit 7260890452eb89185f9ab1e09550938f78ea91db changed the return output tensor exp_counts from 'cpu' to device when calling deepspeed.moe.layer.MoE() This change reduces cpu host overhead when using moe. The device type of self.expert_counts tensor in Fairseq transformer_moe_layer module needs to be changed from cuda from cpu, for ds library >= 0.15.0 Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
transformer_moe_layer: Fix Runtime error
Feature/deepspeed moe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?