include msgctxt when generating .po file #12
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@3dd13 are you sure about this? Can you give an example of what's not working? I know that you have added a test but I don't get 100% the case cause I'm not so familiar with the GetText::RMsgMerge::PoData api... |
Author
|
sorry, my test case was not clear enough. the story was ... I parsed a .pot file and generate a .po file and found out that the msgctxt was missing in the output .po file. |
|
@3dd13 thanks for the clarification! I will try to co and run the test to cast my vote. This looks useful. |
|
I've merged those changes in ruby-gettext/gettext@3518c4d |
fotos
pushed a commit
to skroutz/gettext
that referenced
this pull request
Oct 29, 2012
rgettext -> gettext refs mutoh#12 Reported by mtasaka. Thanks!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the function to parse, modify and print out .po file in my project, but I found out that context was not handled in po generation. so, this is my fix.