refactor(log): Remove deprecated utility/log.h #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove src/libipc/utility/log.h as it's no longer used - All code has been migrated to use the new libipc/imp/log.h interface - The old utility/log.h provided printf-style logging: ipc::log() and ipc::error() - The new imp/log.h provides modern C++ stream-based logging with LIBIPC_LOG() macro - Verified that there are no remaining references to utility/log.h in the codebase This completes the log interface migration by removing the deprecated file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated
src/libipc/utility/log.hfile as it is no longer used in the codebase.Background
All code has been successfully migrated from the old
utility/loginterface to the newimp/loginterface (completed in PR #166).Changes
src/libipc/utility/log.hOld Interface (utility/log.h)
ipc::log()andipc::error()%d,%s, etc.)New Interface (imp/log.h)
LIBIPC_LOG()macro for logger initializationlog.error("msg", arg1, arg2)Verification
✅ Confirmed no remaining references to
utility/log.hin:.cpp,.h,.hpp)This PR completes the log interface migration by removing the deprecated file.
Related