Skip to content

Test why vscode tests fail on anon-var update #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anderson4j wants to merge 2 commits into from
Closed

Test why vscode tests fail on anon-var update #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df1fc27
remove improved semantic analysis (for debugging)
anderson4j Dec 1, 2025
52f8e80
add semanticanalysis
anderson4j Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 22 additions & 20 deletions packages/language-support/src/autocompletion/schemaBasedCompletions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,26 @@ function getNodesFromRelsSet(dbSchema: DbSchema): Map<string, Set<string>> {
return undefined;
}

function findLastVariable(
lastValidElement: NodePatternContext | RelationshipPatternContext,
symbolsInfo: SymbolsInfo,
) {
const variable = lastValidElement.variable();
const isAnonVar = variable === null;
const foundVariable = isAnonVar
? symbolsInfo?.symbolTables
?.flat()
.find(
(entry) =>
entry.definitionPosition >= lastValidElement.start.start &&
entry.definitionPosition <= lastValidElement.stop.stop,
)
: symbolsInfo?.symbolTables
?.flat()
.find((entry) => entry.references.includes(variable.start.start));
return foundVariable;
}

export function completeNodeLabel(
dbSchema: DbSchema,
parsingResult: ParsedStatement,
Expand Down Expand Up @@ -160,16 +180,7 @@ export function completeNodeLabel(
}

if (lastValidElement instanceof RelationshipPatternContext) {
// limitation: not checking anonymous variables
const variable = lastValidElement.variable();
if (variable === null) {
return allLabelCompletions(dbSchema);
}

const foundVariable = symbolsInfo?.symbolTables
?.flat()
.find((entry) => entry.references.includes(variable.start.start));

const foundVariable = findLastVariable(lastValidElement, symbolsInfo);
if (
foundVariable === undefined ||
('children' in foundVariable.labels &&
Expand Down Expand Up @@ -226,16 +237,7 @@ export function completeRelationshipType(
}

if (lastValidElement instanceof NodePatternContext) {
// limitation: not checking anonymous variables
const variable = lastValidElement.variable();
if (variable === null) {
return allReltypeCompletions(dbSchema);
}

const foundVariable = symbolsInfo?.symbolTables
?.flat()
.find((entry) => entry.references.includes(variable.start.start));

const foundVariable = findLastVariable(lastValidElement, symbolsInfo);
if (
foundVariable === undefined ||
('children' in foundVariable.labels &&
Expand Down
Loading
Loading