Skip to content

Conversation

Copy link

Copilot AI commented Nov 27, 2025

Summary

Removed ipx as a direct dependency since it's now consumed indirectly through @netlify/images@1.2.5. The refactoring to use @netlify/images for image proxy handling (completed in earlier commits) made the direct dependency obsolete.

Changes:

  • Removed ipx: "3.1.1" from package.json dependencies
  • Updated package-lock.json accordingly

Test Coverage:

  • 3 integration tests validate image functionality:
    • Remote image transformations (format conversion, sizing, quality)
    • Local image transformations with SSR
    • Image CDN endpoint not shadowed by v2 functions

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: serhalp <1377702+serhalp@users.noreply.github.com>
Copy link
Author

Copilot AI commented Nov 27, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.deno.land
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/cli/cli/bin/run.js dev --offline -p 35827 (dns block)
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/cli/cli/bin/run.js dev --offline -p 40655 (dns block)
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/cli/cli/bin/run.js dev --offline -p 42237 (dns block)
  • images.unsplash.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/cli/cli/bin/run.js dev --offline -p 35827 (dns block)
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/cli/cli/bin/run.js dev --offline -p 42237 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix refactor image handling to use @netlify/images fix: remove ipx dependency (now indirect via @netlify/images) Nov 27, 2025
Copilot AI requested a review from serhalp November 27, 2025 18:49
Copilot finished work on behalf of serhalp November 27, 2025 18:49
@serhalp serhalp marked this pull request as ready for review November 27, 2025 19:12
@serhalp serhalp requested a review from a team as a code owner November 27, 2025 19:12
@serhalp serhalp merged commit 2cb49f4 into keanualoua/ex-536-use-imagehandler-from-netlifyimages Nov 27, 2025
6 checks passed
@serhalp serhalp deleted the copilot/sub-pr-7584 branch November 27, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants