Fix misleading progress indicators with zero ticks #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR fixes misleading progress indicators when both
progressandmaxProgressare equal to zero. Originally both values would reset to one to avoid a DivisionByZero error (#22).Fixes #25
Why is this pull request needed?
This new behavior will show the correct progress values in situations where a programmatic loop has nothing to tick through.
This PR will be released within a new minor version since it changes to behavior of
progressandmaxProgressfor anyone who explicitly checks these values in their code.How does this pull request work?
Values for
progressandmaxProgressno longer reset to one when both values are zero by default. When both values are zero, the percentage is automatically set to 100% without any calculation to avoid a DivisionByZero error.