test: fix and re-enable xmlstore tests; leave websocket ignored #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces unit tests for several key packages: - internal/lib: Added table-driven tests for `newNetconfRequest`, `emitNestedXML`, and `netconfRequest.MarshalXML` in `netconf_lib_test.go`. - internal/transports: Updated `transport_websocket_test.go` by removing the `//go:build exclude` tag, correcting the package name to `transports`, and skipping the `TestWS` function which requires a live server and WASM environment. The skip message provides context. - internal/xmlstore: Added comprehensive table-driven tests in `xmlstore_test.go` for `XMLStore.Insert`, `XMLStore.Marshal`, and the custom `xmlElement.MarshalXML` method, including mocking of `yang.Entry` for thoroughness.
… websocket test ignored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and modernizes unit tests:\n\n- Update
internal/libtests to match current signatures and XML emission.\n- Re-enable and rewriteinternal/xmlstoretests to useyang.Modulesand assert on marshaled XML.\n- Keepinternal/transports/transport_websocket_test.goignored (integration-style) to avoid CI flakes.\n\nAll changes are test-only; no production code modified. Please review the test diffs and let me know if you want the websocket test refactored into a unit test.