fix(info/userFunding): update input argument types to make startTime optional #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR makes the startTime parameter optional in the userFunding API endpoint by changing it from a required UnsignedInteger to v.nullish(UnsignedInteger). This allows users to call the endpoint without specifying a start time.
- Updated the schema definition to make
startTimeoptional usingv.nullish - Removed
startTimefrom test cases to demonstrate the optional usage - Updated documentation example to show simplified usage without
startTime
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/api/info/_methods/userFunding.ts | Changed startTime parameter from required to optional using v.nullish(), updated documentation example |
| tests/api/info/userFunding.test.ts | Removed startTime parameter from both code and CLI test cases to test the optional behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nktkas
deleted the
102-update-infoclientuserfunding-input-argument-types
branch
nktkas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.