feat(subscription): add DEX name parameter to twapStates subscription
#99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds an optional dex parameter to the twapStates subscription method, allowing users to subscribe to TWAP states for a specific DEX (or the main DEX when using an empty string).
Key changes:
- Added optional
dexparameter to theTwapStatesRequestschema - Updated subscription filtering logic to include DEX matching
- Default value handling ensures backward compatibility (defaults to empty string for main DEX)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nktkas
deleted the
97-twapstate-subscription-missed-the-dex-param-currently-valibot-stripped-even-we-put-the-all_dex-param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.