Automate package example data on new asar releases #147
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Defaults to checking out the current repo (Repo B) into the workspace root | ||
|
|
||
| - name: Install R and dependencies (Example) | ||
| uses: r-lib/actions/setup-r@v2 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
|
@k-doering-NOAA any help/advice with this action is also appreciated! This is the one that the asar action is linked to |
Code Metrics Report
Reported by octocov |
|
@Schiano-NOAA Happy to take a look by COB Nov 21 - does that work for you? |
|
@k-doering-NOAA that works great! If you need more time though, there is no time crunch for this feature and can get pushed into December. Thanks :) |
|
Thanks @Schiano-NOAA, I think I will take you up on pushing this to Dec! I'll get it done by 12/5. |
|
@Schiano-NOAA Is this GHA working for you? Like have you tested it and have it do what you wanted? Because this looks good to me, you have the action you need in ASAR, and then this. If not, I fork repos to test new GHAs with them and troubleshoot them there. The warning from github you are seeing is just a suggestion, most of our workflows aren't using a specific hash. |
Ah okay that makes sense! I haven't tried it out as I wasn't sure how I could test it. The forking makes a lot of sense and I could probably try it out that way. |
|
Yeah, with GHA's you never really know until you test it. Just make sure you enable GHAs on your forks. I also have a separate GHA test repo for testing actions that are less complicated and don't require direct repo access. |
|
Linking the corresponding ASAR action: nmfs-ost/asar#385 I agree with with @e-perl-NOAA that testing it (or testing a simpler version with a similar structure) is the only way to know. It looks ok, but I'm assuming this was partially AI generated based on the comments. For me, I've found that the gemini created github actions\ are a helpful starting point, but it sometimes gets some details wrong. Testing helps you know for sure if complicated set-ups like this will work! Let me know if you would like some help testing it in an example repo or in forked versions of the real repositories. Perhaps we can schedule some coworking time to set it up! |
|
@k-doering-NOAA This is super helpful to know! I think setting up some coworking time would be super helpful to me. While I can fork these repos and try to test it out, I do not know where to start to approach it to make it simpler. I used Gemini to help me link it and when making correction, I found myself worried that I would stray from parts that were necessary to the action (without me really understanding it). |
|
just sent a coworking invite! |
|
@k-doering-NOAA Sophie and I had a discussion and we will be moving convert_output from asar into stockplotr soon. In light of this news, it would be helpful in our coworking time to adjust this action to run the conver_output function then within the package to update the example data on each new release of stockplotr. This I think should be a more straightforward action. Thanks for your help! |
|
@Schiano-NOAA and @k-doering-NOAA , I’m working on some tasks I owe {ghactions4r} and realized I’ve already written a GHA that might be adaptable here 🤣. The main workflow is |
|
@Bai-Li-NOAA Ooo that does sound like it would align very well! |
|
Oh, awesome!! @Schiano-NOAA if everything is in 1 repo, that will be much easier to deal with (and maintain over time!) @Bai-Li-NOAA maybe we could try using your reusable workflow? Either where it is now or once it is in ghactions4r? |
asar::convert_output()