Skip to content

Conversation

@araujogui
Copy link
Member

@araujogui araujogui commented Dec 25, 2025

Description

Darken table border colors

Validation

image

Related Issues

Related to nodejs/doc-kit#535

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner December 25, 2025 19:17
Copilot AI review requested due to automatic review settings December 25, 2025 19:17
@vercel
Copy link

vercel bot commented Dec 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Dec 26, 2025 0:29am

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR darkens the table border colors in dark mode by changing the Tailwind CSS class from dark:border-neutral-800 to dark:border-neutral-900, providing better contrast and visual definition for table elements.

  • Updates all table-related dark mode border colors from neutral-800 to neutral-900
  • Ensures consistency across table elements (table container, th/td cells, and mobile responsive layouts)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.83%. Comparing base (33f53a6) to head (a653467).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8457      +/-   ##
==========================================
+ Coverage   73.78%   73.83%   +0.04%     
==========================================
  Files         109      109              
  Lines        9255     9255              
  Branches      314      313       -1     
==========================================
+ Hits         6829     6833       +4     
+ Misses       2424     2420       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member

@araujogui Can you run pnpm version patch in the packages/ui-components directory?

@ovflowd
Copy link
Member

ovflowd commented Dec 25, 2025

Bump, @araujogui

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Dec 26, 2025
@ovflowd
Copy link
Member

ovflowd commented Dec 26, 2025

@nodejs/nodejs-website I'm fast trcking this as a tiny UX improvement.

@ovflowd ovflowd merged commit 790aaf9 into nodejs:main Dec 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants