-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: inline copy feedback for code blocks #8458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8458 +/- ##
==========================================
+ Coverage 73.78% 73.83% +0.04%
==========================================
Files 109 109
Lines 9255 9255
Branches 314 313 -1
==========================================
+ Hits 6829 6833 +4
+ Misses 2424 2420 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
mikeesto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Could you please run prettier on apps/site/components/Common/CodeBox.tsx to fix CI?
| buttonText, | ||
| as = 'a', | ||
| showCopyButton = true, | ||
| copied = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you should add this prop, you can change the buttonText prop to be of type ReactNode and pass the icon directly with the text.
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can remove the whole source of NotificationProvider, including tests, stories and remove it from the Layout too. Which would also allow you to remove the "use client" from the layout. (I think?)
Summary
Rationale
Changes
Fixes #8357