feat: nack support for udsource #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage ? 59.14%
Complexity ? 482
=======================================
Files ? 152
Lines ? 3388
Branches ? 228
=======================================
Hits ? 2004
Misses ? 1219
Partials ? 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
KeranYang
reviewed
Oct 3, 2025
Comment on lines
65
to
74
| // send the message to the observer | ||
| observer.send(message); | ||
| observer.send(constructMessage(index)); | ||
| // keep track of the messages read and not acknowledged | ||
| messages.put(readIndex, true); | ||
| readIndex += 1; | ||
| yetToBeAcked.put(index, true); | ||
| readIndex.incrementAndGet(); |
Member
There was a problem hiding this comment.
Can we move Integer index = readIndex.incrementAndGet(); from L64 to L70 and remove L74?
Member
There was a problem hiding this comment.
Should we move instead of remove Integer index = readIndex.incrementAndGet();? we still want to update the readIndex every time we process a msg right? @yhl25
Contributor
Author
There was a problem hiding this comment.
yes we should move, fixed.
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
KeranYang
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203