-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Support for on success sink #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
…lculation Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage ? 60.78%
Complexity ? 517
=======================================
Files ? 152
Lines ? 3448
Branches ? 242
=======================================
Hits ? 2096
Misses ? 1181
Partials ? 171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
| .setOnSuccessMsg(response.getOnSuccessMessage() == null | ||
| ? SinkOuterClass.SinkResponse.Result.Message.getDefaultInstance() | ||
| : response.getOnSuccessMessage()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current numaflow-core implementation for accepting onSuccess response from server allows sending None in lieu of explicit OnSuccessMessage, but the generated java protobuf for OnSuccessMessage prohibits setting the OnSuccessMessage as null, so a default instance is being sent to the client currently.
This leads to discrepancy between behaviours across different SDKs.
Question: Should we add functionality to numaflow-core to interpret empty value ("") as an indication of sending original message to the onSuccess sink?
…changes Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
…changes Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
|
Please add java doc for public classes. |
Signed-off-by: vtiwari5 <vaibhav_tiwari1@intuit.com>
Closes #206
As part of #3043, we're adding support for OnSuccess sink which allows users to write to a separate sink when writing to primary sink succeeds for example.
This PR aims to add this support to Java SDK as well, giving the users ability to interact with the onSuccess sink.
Local testing:
Brought up a pipeline with a UDSink using java SDK with latest changes:

Able to see messages in the onSuccess UDSink being routed from the primary UDSink:

Mix of messages being written to fallback and onsuccess sink:
