-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add prefix, case-insensitive headers, and format inputs to action #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tive-headers to oasdiff changelog github action
…in oasdiff action
|
Thanks @timonrieger. |
Hey @effoeffi , I cannot add any reviewers to the existing PR, neither using the UI nor the CLI gh pr edit https://github.com/oasdiff/oasdiff-action/pull/64 --add-reviewer effoeffiIn a new PR template I cannot set it either 🤔 Nevertheless, the PR is ready for review. |
effoeffi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, update README with the new parameters.
changelog/entrypoint.sh
Outdated
| readonly case_insensitive_headers="$9" | ||
| readonly format="${10}" | ||
|
|
||
| echo "running oasdiff changelog base: $base, revision: $revision, include_path_params: $include_path_params, exclude_elements: $exclude_elements, composed: $composed, output_to_file: $output_to_file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug output should include the new parameters
done 😄 |
What: Extend
changelogGitHub Action inputs and wire them through toentrypoint.sh.prefix-base: Prefix for base version/pathprefix-revision: Prefix for revision version/pathcase-insensitive-headers: Treat headers case-insensitively (true/false)format: Output format (e.g.,markdown,json)oasdiff changelogas flags:--prefix-base,--prefix-revision--case-insensitive-headers--formatWhy: Increases feature parity with the underlying oasdiff CLI tool
Changes
changelog/action.yml: Add four optional inputs with defaults; append them to theruns.args.changelog/entrypoint.sh: Parse new args and conditionally append matchingoasdiffflags.Usage
entrypoint.shpreserves existing behavior and only appends flags when inputs are provided/true.