-
Notifications
You must be signed in to change notification settings - Fork 52
Add RFC: Add notion of protocol #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems like a needless feature to let users select which implementation of a protocol they want. And that's the only feature here that can't trivially be moved to the output objects. |
|
Big rewrite of the RFC, thank you @henke37 for the (maybe wrong word) spur. I was stuck thinking about protocol and output being separate thing but having them together is better and more lightweight codewise. |
dcae05f to
f42e8ed
Compare
1302f26 to
476d519
Compare
|
|
476d519 to
4c303bf
Compare
4c303bf to
4a7160b
Compare
2aeb8b5 to
4b7be1c
Compare
3e9d450 to
3206aeb
Compare
|
In addition to codec compatibility, we might want to have a flag in the services file to indicate compatibility with HDR (None/PQ/HLG/Both). Services may support HEVC or AV1 codecs for improved compression, but do support HDR delivery or tonemapping to SDR, which would result in viewers receiving a clipped version of the video. Furthermore they may support only one of the HDR formats (e.g. PQ but not HLG). While the number of services supporting HLS or SRT/RIST ingest is currently limited, in the future there may also be outputs such as WHIP or MoQ/WARP that support more than H.264. |
All of this is out of scope of this RFC, it is more related to RFC #39 but selecting a color format is literally a trial and error in OBS as it always was, the user can apply unusable settings in advanced video. This needs a major refactor of settings that can only be done after (maybe while) RFC #53 which is after 39. |
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some further questions.
|
Entering FCP. We've merged the initial PRs, but any further adjustments necessary are still welcome. Once the open conversations are resolved, we will merge this. |
|
I just squashed all the commit together. |
RytoEX
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concerns were resolved. The implementing PRs have been merged anyway, so my approval is more a formality at this point.
RFC 45: Add notion of protocol
Summary
Motivation and Context
Create a better management of outputs, encoders and services with an approach focused on protocols.
Link to RFC