[ADD] estate: Initialize Real state module #1097

abbhi-Odoo · 2026-01-01T09:10:02Z

Estate Module – Key Features:

Creates models to manage estate properties, property types, tags, and offers
Adds menus and actions to provide a clean and user-friendly interface
Adds field validations to prevent incorrect data entry, such as ensuring expected and selling prices are strictly positive
Handles business rule errors gracefully using UserError and ValidationError

- Adds property model with necessary fields. - chapter 2,3

- Remove duplicate garden field in estate_property.py. - Remove unnecessary space. - chapter 2,3

robodoo · 2026-01-01T09:10:05Z

-This change introduces the basic UI navigation for the Estate module. -It adds window actions and a menu hierarchy to access property records. -It configures default field behaviors such as read-only fields, defaults, and copy restrictions. - chapter 4,5,6

bit-odoo

Hello,
Good Work!

Can you please adapt your PR message and title acrroding to the guidelines.
Thanks

bit-odoo · 2026-01-02T05:30:49Z

estate/models/estate_property.py

+from odoo import models, fields
+from dateutil.relativedelta import relativedelta


Please follwe this guideliances.
https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#imports

- Add property types and tags models - Link properties with buyers, salespersons, and types - chapter 6,7

-Implemented a One2many field to link estate properties with their related offers. -chapter: 7

- Implemented computed fields using @api.depends - Added onchange methods to update values dynamically in the UI - Chapter: 8

bit-odoo

Hello,
Good Work!

I have left some comments.
Please update your PR title and description.
Thanks

bit-odoo · 2026-01-06T08:01:12Z

estate/models/estate_property.py

+
+    name = fields.Char(required=True)
+    description = fields.Text()
+    postcode = fields.Char()


Why postcode is char() field?

estate/models/estate_property.py

bit-odoo · 2026-01-06T08:05:10Z

estate/models/estate_property_offer.py

+from odoo import models, fields, api
+
+from dateutil.relativedelta import relativedelta


Please follow the import guidelines. Do not do same mistake repeatedly.

bit-odoo · 2026-01-06T08:06:01Z

estate/models/estate_property_offer.py

+    _description = "Estate Property Offer"
+
+    price = fields.Float(string="Price")
+


Unneccary space.

bit-odoo · 2026-01-06T08:06:10Z

estate/models/estate_property_offer.py

+        ("accepted", "Accepted"),
+        ("rejected", "Rejected"),
+    ], copy=False)
+


Unneccary space.

bit-odoo · 2026-01-06T08:06:15Z

estate/models/estate_property_offer.py

+    ], copy=False)
+
+    partner_id = fields.Many2one("res.partner", required=True)
+


Unneccary space.

bit-odoo · 2026-01-06T08:06:20Z

estate/models/estate_property_offer.py

+        string="Property",
+        required=True
+    )
+


Unneccary space.

bit-odoo · 2026-01-06T08:06:26Z

estate/models/estate_property_offer.py

+        string="Validity (days)",
+        default=7
+    )
+


Unneccary space.

bit-odoo · 2026-01-06T08:08:51Z

estate/views/estate_menus.xml

+                  parent="estate_menu_root"
+                  sequence="15"/>
+
+        <menuitem id="estate_menu_properties"


Please refer to this documentation for XML IDs and naming- https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming

abbhi-Odoo · 2026-01-06T11:05:30Z

I have made all changes according to the review suggestions. Thank you.

- Added sold and cancel actions for property offers - Linked accepted offer to property selling price and buyer - Chapter: 9

- Added constraints to enforce unique tags and properties - Fixed style issues and improved validation logic - Chapter: 10

bit-odoo

Hello,
Can you please update your PR description.
I have made some comments.

Thanks

bit-odoo · 2026-01-09T07:56:16Z

estate/__manifest__.py

@@ -0,0 +1,17 @@
+{
+    'name': "Estate",


Please use the same quote throughout the file.

bit-odoo · 2026-01-09T07:59:48Z

estate/models/estate_property_offer.py

+        for record in self:
+            if record.property_id.selling_price or record.status == "accepted":
+                raise UserError("Offer is already accepted")
+            self.status = "accepted"


Why did you used self?

bit-odoo · 2026-01-09T08:00:38Z

estate/models/estate_property_offer.py

+            if record.property_id.selling_price or record.status == "accepted":
+                raise UserError("Offer is already accepted")
+            self.status = "accepted"
+            rejected_offer = self.search([


If we are expecting multiple valus then the variable name should be like rejected_offers.
And again why did you used self inside the loop?

- Added list and form views for property types. - Enabled ordering in property type list. - Hide Accept/Reject buttons once an offer is accepted. - Chapter: 11

abbhi-Odoo · 2026-01-09T12:14:18Z

I have made all changes according to the review suggestions. Thank you.

- Improved the user interface of the Estate module by refining list and form views. - Added inline list views, statusbar widgets, conditional visibility of fields and buttons, editable list views, color decorations, default search filters, and stat buttons. - Chapter: 11

bit-odoo

Hello,
Can you please improve your PR title.
Thanks

bit-odoo · 2026-01-13T05:43:46Z

estate/models/estate_property.py

+        for record in self:
+            if record.state == "sold":
+                raise RedirectWarning("A sold property cannot be cancelled",


We can use filtered here, and it is good to make the error message translatable.

bit-odoo · 2026-01-13T05:44:20Z

estate/models/estate_property.py

+        for record in self:
+            if record.state == "cancelled":
+                raise UserError("A cancelled property cannot be sold")


We can use filtered here, and it is good to make the error message translatable.

bit-odoo · 2026-01-13T05:45:26Z

estate/models/estate_property_offer.py

+            if record.property_id.selling_price or record.status == "accepted":
+                raise UserError("Offer is already accepted")
+            record.status = "accepted"
+            rejected_offers = record.search([


It is not good to use a search() inside the loop.

abbhi-Odoo added 3 commits December 31, 2025 16:31

[ADD] estate: created estate Property model and manifest file

ac7ad92

- Adds property model with necessary fields. - chapter 2,3

[FIX] estate: fix model and ruff style issues

04be844

- Remove duplicate garden field in estate_property.py. - Remove unnecessary space. - chapter 2,3

[FIX] estate: fix model and ruff style issues

95af12b

- Remove duplicate garden field in estate_property.py. - Remove unnecessary space. - chapter 2,3

abbhi-Odoo force-pushed the 19.0-estate-tutorial-abbhi branch from b4ab976 to 316dad9 Compare January 1, 2026 12:32

abbhi-Odoo force-pushed the 19.0-estate-tutorial-abbhi branch from 316dad9 to 2111cd7 Compare January 1, 2026 12:48

bit-odoo reviewed Jan 2, 2026

View reviewed changes

[ADD] estate: complete filters,group by with properties relations

4934255

- Add property types and tags models - Link properties with buyers, salespersons, and types - chapter 6,7

abbhi-Odoo changed the title ~~19.0 estate tutorial abbhi~~ [ADD] estate:Initialize Real state module Jan 2, 2026

[IMP] estate: complete relations between models

e50a962

-Implemented a One2many field to link estate properties with their related offers. -chapter: 7

abbhi-Odoo force-pushed the 19.0-estate-tutorial-abbhi branch from ebf724a to e50a962 Compare January 5, 2026 10:26

[IMP] estate: add computed fields and onchange logic

16bb220

- Implemented computed fields using @api.depends - Added onchange methods to update values dynamically in the UI - Chapter: 8

bit-odoo reviewed Jan 6, 2026

View reviewed changes

abbhi-Odoo changed the title ~~[ADD] estate:Initialize Real state module~~ [ADD] estate: Initialize Real state module Jan 6, 2026

[IMP] estate: add property offer workflow

c427696

- Added sold and cancel actions for property offers - Linked accepted offer to property selling price and buyer - Chapter: 9

abbhi-Odoo force-pushed the 19.0-estate-tutorial-abbhi branch from ed943ba to c427696 Compare January 7, 2026 09:44

[IMP] estate: add SQL and Python constraints

52a77f4

- Added constraints to enforce unique tags and properties - Fixed style issues and improved validation logic - Chapter: 10

abbhi-Odoo force-pushed the 19.0-estate-tutorial-abbhi branch from defd568 to 52a77f4 Compare January 9, 2026 04:49

bit-odoo reviewed Jan 9, 2026

View reviewed changes

[IMP] estate: improve property type views and offer button behavior

2b76c19

- Added list and form views for property types. - Enabled ordering in property type list. - Hide Accept/Reject buttons once an offer is accepted. - Chapter: 11

bit-odoo reviewed Jan 13, 2026

View reviewed changes

		from odoo import models, fields
		from dateutil.relativedelta import relativedelta

		from odoo import models, fields, api

		from dateutil.relativedelta import relativedelta

		_description = "Estate Property Offer"

		price = fields.Float(string="Price")

		], copy=False)

		partner_id = fields.Many2one("res.partner", required=True)

[ADD] estate: Initialize Real state module #1097

Are you sure you want to change the base?

[ADD] estate: Initialize Real state module #1097

Uh oh!

Conversation

abbhi-Odoo commented Jan 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Jan 1, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

bit-odoo Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abbhi-Odoo commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abbhi-Odoo commented Jan 9, 2026

Uh oh!

bit-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abbhi-Odoo commented Jan 1, 2026 •

edited

Loading

bit-odoo Jan 2, 2026 •

edited

Loading

abbhi-Odoo commented Jan 6, 2026 •

edited

Loading