[ADD] estate:Initialize new module #1101
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Define manifest file -Define new model and security file Chapter 1: Architecture Overview Chapter 2: A New Application Chapter 3: Models And Basic Fields Chapter 4: Security - A Brief Introduction
|
|
- Created estate property form and list view - Created search bar fields Chapter 5: Finally, Some UI To Play With Chapter 6: Basic Views
mibav-odoo
force-pushed
the
19.0-estate-tutorial-mibav
branch
from
1e865d3 to
ce13e13
Compare
bit-odoo
reviewed
Jan 2, 2026
There was a problem hiding this comment.
Hello,
Great job so far!
i have added some comments, and can you please add a linter like Ruff.
Commit title like [ADD] estate: basic menus, form and list views
ce13e13
You can use this to write a proper commit message.
https://odoo-commit.firebaseapp.com/
Thanks
estate/models/estate_property.py
Outdated
Comment on lines
1
to
2
| from odoo import fields, models | ||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
Can you please follwe this guidelines?
4712d52
estate/models/estate_property.py
Outdated
Comment on lines
22
to
27
| garden_orientation = fields.Selection( | ||
| string='Garden Orientation', | ||
| selection=[('north', 'North'), | ||
| ('south', 'South'), | ||
| ('east', 'East'), | ||
| ('west', 'West')]) |
There was a problem hiding this comment.
Suggested change
| garden_orientation = fields.Selection( | |
| string='Garden Orientation', | |
| selection=[('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West')]) | |
| garden_orientation = fields.Selection( | |
| string='Garden Orientation', | |
| selection=[ | |
| ('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West') | |
| ] | |
| ) |
Comment on lines
28
to
38
| state = fields.Selection( | ||
| string='State', | ||
| default='new', | ||
| required=True, | ||
| copy=False, | ||
| selection=[('new', 'New'), | ||
| ('offer received', 'Offer Received'), | ||
| ('offer accepted', 'Offer accepted'), | ||
| ('sold', 'Sold'), | ||
| ('cancelled', 'Cancelled')] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| state = fields.Selection( | |
| string='State', | |
| default='new', | |
| required=True, | |
| copy=False, | |
| selection=[('new', 'New'), | |
| ('offer received', 'Offer Received'), | |
| ('offer accepted', 'Offer accepted'), | |
| ('sold', 'Sold'), | |
| ('cancelled', 'Cancelled')] | |
| ) | |
| state = fields.Selection( | |
| string='State', | |
| default='new', | |
| required=True, | |
| copy=False, | |
| selection=[ | |
| ('new', 'New'), | |
| ('offer received', 'Offer Received'), | |
| ('offer accepted', 'Offer accepted'), | |
| ('sold', 'Sold'), | |
| ('cancelled', 'Cancelled') | |
| ] | |
| ) |
Created search views for the estate.property model. Added menu items and actions to open the property Type Created new model estate.property.type Chapter 6: Basic Views
mibav-odoo
force-pushed
the
19.0-estate-tutorial-mibav
branch
from
90db89e to
c2aec78
Compare
Created Many2one, Many2many, and One2many relations between models. Added a new list and form view for the estate.property.offer model. Updated the property view. Chapter 7: Relations Between Models
Author
|
I have implemented all the suggested changes in the latest commits. |
Define 'total_area' and 'best_price' as computed fields on the property model. Add date_deadline and validity with inverse methods to handle offer durations. Use onchange to update garden area and orientation when garden is toggled. Chapter 8: Computed Fields And Onchanges
bit-odoo
reviewed
Jan 7, 2026
bit-odoo
left a comment
bit-odoo
left a comment
There was a problem hiding this comment.
Hello,
Good Work!
I have added some comments.
Can you please adapt your PR description.
Thanks
estate/models/estate_property.py
Outdated
Comment on lines
54
to
55
| total_area = fields.Integer(compute="_compute_total") | ||
| best_price = fields.Float(compute="_compute_maximum") |
There was a problem hiding this comment.
compute method name should be _compute_<field_name>.
estate/security/ir.model.access.csv
Outdated
| access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1 | ||
| access_estate_property_type,access_estate_property_type,model_estate_property_type,base.group_user,1,1,1,1 | ||
| access_estate_property_tag,access_estate_property_tag,model_estate_property_tag,base.group_user,1,1,1,1 | ||
| access_estate_property_offer,access_estate_property_offer,model_estate_property_offer,base.group_user,1,1,1,1 No newline at end of file |
estate/views/estate_menus.xml
Outdated
| parent="estate_property_menu_root" | ||
| sequence="1"/> | ||
| <menuitem | ||
| id="estate_property_properties" |
There was a problem hiding this comment.
Please refer to this documentation for XML IDs and naming - https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#xml-ids-and-naming
Comment on lines
20
to
24
| <field name="expected_price"/> | ||
| <field name="selling_price"/> | ||
| <field name="garden_area"/> | ||
| <field name="garden_orientation"/> | ||
| <field name="state"/> |
There was a problem hiding this comment.
We can make some fields optional for better readability.
…mments -Add accept/refuse actions for property offers with validation. -Update property state and selling price on offer acceptance -Add action buttons for offers and properties -Add SQL constraint -Rename compute methods to follow naming conventions -Fix XML IDs according to guidelines -Make non-essential fields optional for better form readability -Add missing newline at end of access rights CSV file Chapter 9: Ready For Some Action Chapter 10: Constraints
mibav-odoo
force-pushed
the
19.0-estate-tutorial-mibav
branch
from
5458010 to
cfaae95
Compare
Author
|
Thank You for your feedback. I have implemented the changes and updated the PR accordingly. |
- Added Python constraints for validation - Improved button styling - Added widget and list order to enhance UI - Added a default filter
mibav-odoo
force-pushed
the
19.0-estate-tutorial-mibav
branch
from
34536b2 to
b8ed874
Compare
- Added Stat button to XML views. - Defined new relationship for Stat button - Improved button UI design and integration within views - Introduced Tags Color field and made it visible in the list view Chapter 11: Add The Sprinkles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the functionality of Real estate module. Key features include the creation of models, fields, views and business logic for property and offer management.
The implementation focuses on optimizing property and offer workflow with computed fields, constrains and decorators.