Mango with promises #32
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds promise-returning methods to Mango and related classes as an alternative to non-blocking with callbacks. For this, it relies on Mojo::Promise as introduced with Mojolicious 7.53.
All of Mango continues to work with older Mojolicious as it used to. Only, if Mojo::Promise is not available, the new methods, like
$collection->find_one_pand$bulk->execute_p, don't do anything but to throw exceptions like:In the same vein, tests cover the new methods if Mojo::Promise is available and, if not, the corresponding tests are ignored.
Most of the patch is repetitive documentation and the new tests. The code change is small, consisting of a new (internal) helper class Mango::Promises that generate the _p methods from the original methods (like
Mango::Bulk::execute_pfromMango::Bulk::execute) and the inclusion of code like below to each class