-
Notifications
You must be signed in to change notification settings - Fork 32
add test-list/tor-targets to ooniapi probe services #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
c18384c to
77b980d
Compare
|
squashed fixes |
ooniapi/common/src/common/config.py
Outdated
| failed_reports_bucket: str = ( | ||
| "" # for uploading reports that couldn't be sent to fastpath | ||
| ) | ||
| tor_targets: str = "" # path to json file containing Tor bridges and DirAuth endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really can't have a file path here because of how this runs in AWS
This is deployed as an ECS task, so although it has a disk, the disk is recreated every time a new instance of the microservice is spawned. So we can't really assume the initial state of the disk
This cannot be part of an environment variable either since the file might be too long for parameter store (maximum length of standard parameter store is 4096 chars: https://docs.aws.amazon.com/systems-manager/latest/userguide/systems-manager-parameter-store.html#parameter-size-limits)
So maybe the only solution we have left is serving it from s3, but we still don't have a private bucket for this purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a hack is to pull it out of torbrowser git
https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/main/projects/tor-expert-bundle/pt_config.json?ref_type=heads
|
Related to #807 |
this adds a new environment variable "TOR_TARGETS" which points to a json file
4574144 to
49bd00f
Compare
adds config for "TOR_TARGETS" , which points to a json file in a S3 bucket, served by endpoint api/v1/test-list/tor-targets