Skip to content

R044 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yolile wants to merge 6 commits into
base: main
Choose a base branch
from
Open

R044 #100

yolile wants to merge 6 commits into from

Conversation

@yolile
Copy link
Member

@yolile yolile commented Jun 14, 2024

closes #94

@yolile
Copy link
Member Author

yolile commented Jun 14, 2024

I'm still missing the documentation and the contactPoint part but you can review some of the logic already @jpmckinney

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9521824556

Details

  • 41 of 42 (97.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 92.466%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/indicators/r044.rs 38 39 97.44%
Totals Coverage Status
Change from base Build 9310438025: 0.1%
Covered Lines: 1436
Relevant Lines: 1553
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9552204589

Details

  • 56 of 58 (96.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.479%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/indicators/r044.rs 53 55 96.36%
Totals Coverage Status
Change from base Build 9310438025: 0.2%
Covered Lines: 1451
Relevant Lines: 1569
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9552807569

Details

  • 56 of 58 (96.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 92.479%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/indicators/r044.rs 53 55 96.36%
Totals Coverage Status
Change from base Build 9310438025: 0.2%
Covered Lines: 1451
Relevant Lines: 1569
💛 - Coveralls

@yolile yolile marked this pull request as ready for review June 17, 2024 18:27
@yolile yolile requested a review from jpmckinney June 17, 2024 18:27
@yolile
Copy link
Member Author

yolile commented Jun 17, 2024 •
edited
Loading

I'm not sure why the documentation build is failing. Should we ensure the output order is always the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpmckinney jpmckinney Awaiting requested review from jpmckinney

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

indicators: add R044 Business similarities between suppliers (or bidders): common addresses, personnel, phone numbers, etc.

3 participants

@yolile @coveralls