schema-strict: add more validation keywords #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jpmckinney
reviewed
Feb 11, 2022
Comment on lines
+247
to
+259
| elif key in ['quantity', 'durationInDays', 'numberOfTenderers']: | ||
| value['minimum'] = 0 | ||
| elif key in ['Organization', 'OrganizationReference']: | ||
| value['required'] = ['id', 'name'] | ||
| value['properties']['name']['type'] = "string" | ||
| value['properties']['id']['type'] = "string" | ||
| elif key in ['Amendment', 'RelatedProcess']: | ||
| value['required'] = ['id'] | ||
| value['properties']['id']['type'] = "string" | ||
| elif key == 'id': | ||
| if 'type' in value: | ||
| if 'integer' in value['type']: | ||
| value['type'].remove('integer') |
Member
There was a problem hiding this comment.
OCDS Kit (despite the name) has tools that are reusable by other JSON Schema standards (like BODS). We should put this logic in the standard repository. Since this leaves only email as key-based logic, we can move it as well.
Contributor
Author
There was a problem hiding this comment.
Sounds good - I've done that in open-contracting/standard#1480 so I'll close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-contracting/standard#1046
TO-DO: