feat: authenticating when using remote archive #978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Work in progress PR, opening early to collect feedback.
Add
auth-tokenoption to the CLI that allows configuring authentication when fetching registry from a remote archive.Notes
auth-tokenis passed and handled separately from the virtual directory path string as the usual@character separating userinfo portion of the URL from the host is reserved for therefspec. Taking the token from the userinfo portion of the URL would be an alternative to the approach in this commit but would make the parsing a little bit more cumbersome. I am open to both approach and happy to adjust the code to whatever the OpenTelemetry team deems better.Open for discussion
Bearerscheme in theAuthorizationheader. For example, most guides using GitHub PATs usetokenscheme (even thoughBearerworks too). UsingBearermight be an OK compromise for the initial version.Fixes: #430