-
Notifications
You must be signed in to change notification settings - Fork 1
separate DataTypes model #31
Conversation
types extracted from CAOM and then imported add double,int32, int64 primitive types
|
lets not forget to revisit the type names..
I'd vote for int32, int64, real64 |
|
I would want to look at the IEEE floating point standard for the correct names to use. A cursory glance says "single" and "double" (precision) are only common names, but no sane programming language would have used |
|
https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=8766229 3.1.1 says: 3.6 the tables use binaryW and decimalW for different width (bits); since we use both binary and decimal (ascii) interchange, neither of those styles are really correct for what we are after... to specific to serialisation. Note that while decimal32 is in the tables in 3.6, it is not considered a "basic format" (definition in 2.1) I think we could get away with the ivoa base model having So, I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on the Shape extractions.
- If this goes outside CAOM, the descriptions should lose the context text.. "on the sky".
- I had gotten into my head that Point was a Shape, but it is not... feels like it should be.
- MultiShape is in the same boat as Polygon since it has an attribute with [1..*] Shape-s.
- MultiShape is a collection of Shapes with no logic associating them? Maybe it's in the text, but what use case does that support? or is the logic imposed by the usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- yes
- there is lots of prior art/design that says not to do that
- yes, but that rule needs to relax
- DALI now specifies xtype="multishape" which defines it as "union"; that is the intent here
Of course, with 4 we are doing things in the wrong order: specify serialization first and then the model, but the DALI thing is intended to exactly do what CAOM needs so I prefer to think of it as a two-point boundary value problem :-)
types extracted from CAOM and then imported
add double,int32, int64 primitive types
draft: DataTypes name and location TBD