Skip to content

Conversation

@awais786
Copy link
Contributor

@awais786 awais786 commented Dec 8, 2025

openedx/public-engineering#458

  • Removed Django 4.2 and run make upgrade with django5.2
  • Updated all Python dependencies to their latest compatible versions
  • Cleaned up test environments and CI configuration to remove Django 4.2 references

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes support for Django 4.2 and bumps the package version to 3.5.0. The change aligns with the project's evolution to focus on newer Django versions (5.2+) and includes comprehensive dependency updates across all requirement files.

Key Changes:

  • Removed Django 4.2 from supported versions and updated package version to 3.5.0
  • Updated all Python dependencies to their latest compatible versions
  • Cleaned up test environments and CI configuration to remove Django 4.2 references

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
user_tasks/init.py Bumped version from 3.4.0 to 3.5.0
tox.ini Removed django42 from envlist and removed corresponding dependency specification
setup.py Removed Django 4.2 classifier from package metadata
requirements/test.txt Updated test dependencies including pytest, coverage, and Django to latest versions
requirements/quality.txt Updated code quality tools including pylint, isort, and related packages
requirements/pip.txt Updated pip and setuptools to latest versions
requirements/pip-tools.txt Updated pip-tools and build packages
requirements/doc.txt Updated documentation dependencies including Sphinx and related packages
requirements/dev.txt Updated combined development dependencies
requirements/ci.txt Updated CI-specific dependencies including tox and virtualenv
requirements/base.txt Updated base runtime dependencies including Django 5.2.9, Celery 5.6.0, and DRF 3.16.1
CHANGELOG.rst Documented the removal of Django 4.2 support in version 3.5.0 release notes
.github/workflows/ci.yml Removed django42-celery53-drflatest from CI test matrix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tox.ini Outdated
[tox]
envlist =
py{311,312}-django{42, 52}-celery{53, 54}-drf{313,latest}
py{311,312}-django{52}-celery{53, 54}-drf{313,latest}
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent spacing in the tox environment list. The celery specification has {53, 54} with a space after the comma, while other specifications like {311,312} don't have spaces. Consider using consistent spacing: either celery{53,54} or update all to use spaces for consistency.

Suggested change
py{311,312}-django{52}-celery{53, 54}-drf{313,latest}
py{311,312}-django{52}-celery{53,54}-drf{313,latest}

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.90%. Comparing base (e238b10) to head (1f4ebb4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #449   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          18       18           
  Lines         488      488           
  Branches       55       55           
=======================================
  Hits          468      468           
  Misses         19       19           
  Partials        1        1           
Flag Coverage Δ
unittests 95.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- '3.12'
toxenv: [django42-celery53-drflatest, django52-celery54-drflatest,
quality, docs]
toxenv: [django52, quality, docs]
Copy link
Contributor Author

@awais786 awais786 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edx-platform already using following versions so need to add different versions.

djangorestframework==3.16.1
celery==5.6.0

click-repl==0.3.0
# via celery
django==4.2.25
django==5.2.9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django52 appeared here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant