-
Notifications
You must be signed in to change notification settings - Fork 17
fix: Dropped django42 support. #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes support for Django 4.2 and bumps the package version to 3.5.0. The change aligns with the project's evolution to focus on newer Django versions (5.2+) and includes comprehensive dependency updates across all requirement files.
Key Changes:
- Removed Django 4.2 from supported versions and updated package version to 3.5.0
- Updated all Python dependencies to their latest compatible versions
- Cleaned up test environments and CI configuration to remove Django 4.2 references
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| user_tasks/init.py | Bumped version from 3.4.0 to 3.5.0 |
| tox.ini | Removed django42 from envlist and removed corresponding dependency specification |
| setup.py | Removed Django 4.2 classifier from package metadata |
| requirements/test.txt | Updated test dependencies including pytest, coverage, and Django to latest versions |
| requirements/quality.txt | Updated code quality tools including pylint, isort, and related packages |
| requirements/pip.txt | Updated pip and setuptools to latest versions |
| requirements/pip-tools.txt | Updated pip-tools and build packages |
| requirements/doc.txt | Updated documentation dependencies including Sphinx and related packages |
| requirements/dev.txt | Updated combined development dependencies |
| requirements/ci.txt | Updated CI-specific dependencies including tox and virtualenv |
| requirements/base.txt | Updated base runtime dependencies including Django 5.2.9, Celery 5.6.0, and DRF 3.16.1 |
| CHANGELOG.rst | Documented the removal of Django 4.2 support in version 3.5.0 release notes |
| .github/workflows/ci.yml | Removed django42-celery53-drflatest from CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tox.ini
Outdated
| [tox] | ||
| envlist = | ||
| py{311,312}-django{42, 52}-celery{53, 54}-drf{313,latest} | ||
| py{311,312}-django{52}-celery{53, 54}-drf{313,latest} |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Inconsistent spacing in the tox environment list. The celery specification has {53, 54} with a space after the comma, while other specifications like {311,312} don't have spaces. Consider using consistent spacing: either celery{53,54} or update all to use spaces for consistency.
| py{311,312}-django{52}-celery{53, 54}-drf{313,latest} | |
| py{311,312}-django{52}-celery{53,54}-drf{313,latest} |
98e4862 to
49b06a1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 18 18
Lines 488 488
Branches 55 55
=======================================
Hits 468 468
Misses 19 19
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b7082d to
96ea362
Compare
| - '3.12' | ||
| toxenv: [django42-celery53-drflatest, django52-celery54-drflatest, | ||
| quality, docs] | ||
| toxenv: [django52, quality, docs] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edx-platform already using following versions so need to add different versions.
djangorestframework==3.16.1
celery==5.6.0
2244b62 to
e067af1
Compare
| click-repl==0.3.0 | ||
| # via celery | ||
| django==4.2.25 | ||
| django==5.2.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django52 appeared here.
openedx/public-engineering#458
Django 4.2and run make upgrade withdjango5.2