Skip to content

Conversation

@marslanabdulrauf
Copy link
Contributor

Relevant Ticket

https://github.com/mitodl/hq/issues/6505

Description

Since course_id is a text field, filtering on course_id directly won’t work because Elasticsearch tokenizes it.

How can we test ?

  1. Make sure your notes setup is working properly with edX and its using Elasticsearch
  2. Add notes on any course
  3. Search for that Note -- It should be searchable

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 21, 2025

Thanks for the pull request, @marslanabdulrauf!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 21, 2025
@marslanabdulrauf marslanabdulrauf force-pushed the marslan/6505-text-search branch 2 times, most recently from 26850ac to 0f84f67 Compare March 24, 2025 09:25
@marslanabdulrauf marslanabdulrauf force-pushed the marslan/6505-text-search branch from 0f84f67 to 2e3df54 Compare March 24, 2025 09:33
@marslanabdulrauf marslanabdulrauf changed the title Text search fixed for elasticsearch for course_id field [WIP] Text search fixed for elasticsearch for course_id field Mar 24, 2025
@marslanabdulrauf
Copy link
Contributor Author

The issue could be with the mappings, closing it for now.

@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants