Skip to content

ojodb v3 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
brancengregory wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

ojodb v3 #192

brancengregory wants to merge 10 commits into from

Conversation

@brancengregory
Copy link
Member

@brancengregory brancengregory commented Aug 14, 2025 •
edited
Loading

  • Overhaul ojo_auth
  • Overhaul ojo_connect and friends
  • Remove theming functions now living in {ojothemes}

@brancengregory
Auth (#191)
322521c 
* Overhaul ojo_auth

* Update wordlist

* Add db_config to pkgdown index

* Move ssl_mode argument before other ssl arguments
@brancengregory brancengregory added this to the ojodb 3.0 milestone Aug 14, 2025
This was linked to issues Aug 14, 2025
Move metrics functions from oscn-scraper here #176
Closed
Make system level dependencies explicit #180
Closed
ojo_auth overhaul #185
Closed
ojo_connect overhaul #190
Closed
@brancengregory
Connection arguments (#194)
7076d1d 
* Add driver and database db_config args; add function to create database connection strings

* Add note for todo
@brancengregory
Overhaul connection management (#199)
e8b2a69 
* Add driver and database db_config args; add function to create database connection strings

* Add note for todo

* Overhauls connection management and updates tests accordingly
@brancengregory brancengregory requested a review from Copilot August 15, 2025 05:22
@brancengregory brancengregory marked this pull request as ready for review August 15, 2025 05:23
@brancengregory brancengregory marked this pull request as draft August 15, 2025 05:23
@brancengregory brancengregory removed this from the ojodb 3.0 milestone Aug 15, 2025
Copilot AI reviewed Aug 15, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@brancengregory
Tests (#202)
2603c92 
* Edit tests to add skip_if_no_db

* Turn off parallel testing

* Add new vars to gh workflows

* Update wordlist

* Set minimum R version; update dependencies, adding digest and RSQLite, removing ggplot2, and downgrading lifecycle to suggests

* Update github env vars

* Fix tests

* Add air config and format
@brancengregory
Standardize naming conventions; remove ojo_search_minutes
dcdfdd3
@brancengregory
Update documentation
24c3bdf
@brancengregory
Sort all schema table list by schema then table name
458ba53
@brancengregory
Remove ojo_env and ojo_show_row
67e407b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ojo_connect overhaul ojo_auth overhaul Make system level dependencies explicit Move metrics functions from oscn-scraper here

2 participants

@brancengregory